[sfml] wrong textures after switching animations

tobi

Hello,

I'm currently working in a team on a top down 2D arena brawler. Our designer decided to use Spine for the characters' animations. We currently got idle and run animations for 8 directions. Each direction has it's own file. The idle and run animations use different textures/attachment (as far as I know). Whenever the character's movement changes I switch the current DrawableSkeleton and set the animation to running or idle by calling AnimationState_setAnimationByName.

When I start the game and the idle animation is played everything looks fine:
Loading Image

I start running and it still looks as expected:
Loading Image

But then if I stop running the idle animation is wrong:
Loading Image

The textures don't change back and the render order seems to be wrong. Any clue to why this is?

This is how I load animations:

void TextureManager::loadAnimation(CharacterType type, Direction direction, const std::string& path)
{
   Atlas* atlas = Atlas_createFromFile((path + ".atlas").c_str(), 0);
   SkeletonJson* json = SkeletonJson_create(atlas);
   json->scale = 0.3f;
   SkeletonData* data = SkeletonJson_readSkeletonDataFile(json, (path + ".json").c_str());
   SkeletonJson_dispose(json);
   m_animations[Key(type, direction)] = new spine::SkeletonDrawable(data);
}

Updating with:

m_pDrawable->update(elapsedTime.asSeconds());

Changing animation/drawable:

m_pDrawable = m_pPlayer->getTexManager()->getAnimation(m_type, direction);
AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle", true);

tobi

BinaryCats

most likely it isn't your problem, it is the animators. He needs to key the draw order/slots. He has left them in a bad position/visability at the end of the animation. he needs to key them at the start of idle

tobi

Thanks! That's what I thought (or hoped ^^) as well.

stink3finger

BinaryCats ：
most likely it isn't your problem, it is the animators. He needs to key the draw order/slots. He has left them in a bad position/visability at the end of the animation. he needs to key them at the start of idle

Hey, I am the designer.

I already key the draw order, like my screenshot is showing :

Loading Image

or am I doing something wrong?

cheers

stink3

BinaryCats

hmm it looks ok. im going to have to think about this one :think:

tobi

We are using Spine Runtimes Version 2.1 and SFML 2.2. But I doubt this has any meaning to this problem ^^

BinaryCats

only thing I can think of is idle isn't playing (after the run). Are you sure it definitely is, and you are still updating the skeleton once run has stopped?

tobi

ok let's see here is everything I do with animations:

loading (for south skeleton/animation):

std::map<Key, spine::SkeletonDrawable*> m_animations;

loadAnimation(THIEF, SOUTH, "data/Thief/Walking South/front");

void TextureManager::loadAnimation(CharacterType type, Direction direction, const std::string& path)
{
   Atlas* atlas = Atlas_createFromFile((path + ".atlas").c_str(), 0);
   SkeletonJson* json = SkeletonJson_create(atlas);
   json->scale = 0.3f;
   SkeletonData* data = SkeletonJson_readSkeletonDataFile(json, (path + ".json").c_str());
   if (!data)
      std::cerr << "Resource Manager: failed to load Animation " << Key(type, direction).toString() << " from \"" << path << "\"!" << std::endl;
   else
   {
      SkeletonJson_dispose(json);
      m_animations[Key(type, direction)] = new spine::SkeletonDrawable(data);
   }
}

//this is how I get them later
spine::SkeletonDrawable* TextureManager::getAnimation(CharacterType type, Direction direction)
{
   Key key(type, direction);
   if (m_animations.find(key) == m_animations.end())
      std::cerr << "Resource Manager: Animation " << key.toString() << " not found!" << std::endl;
   return m_animations[key];
}

update:
Whenever the movingdirection changes I get the new drawable. If the character stops moving the movingdirection is NONE and the viewingdirection selects the drawable and animaiton.

void Thief::updateMovingDirection()
{
    m_pDrawable = m_pPlayer->getTexManager()->getAnimation(m_type, 
    m_movingDirection == NONE ? m_viewingDirection : m_movingDirection);

switch (m_movingDirection)
  {
  case NORTH:
     AnimationState_setAnimationByName(m_pDrawable->state, 0, "running_v4", true);
     break;
  case EAST:
     AnimationState_setAnimationByName(m_pDrawable->state, 0, "running_right", true);
     break;
  case SOUTH:
     AnimationState_setAnimationByName(m_pDrawable->state, 0, "running3", true);
     break;
  case WEST:
     AnimationState_setAnimationByName(m_pDrawable->state, 0, "running_left", true);
     break;
  case NORTH_EAST:
     AnimationState_setAnimationByName(m_pDrawable->state, 0, "running_right", true);
     break;
  case SOUTH_EAST:
     AnimationState_setAnimationByName(m_pDrawable->state, 0, "running_right", true);
     break;
  case SOUTH_WEST:
     AnimationState_setAnimationByName(m_pDrawable->state, 0, "running_left", true);
     break;
  case NORTH_WEST:
     AnimationState_setAnimationByName(m_pDrawable->state, 0, "running_left", true);
     break;
  case NONE: 
     switch (m_viewingDirection)
     {
     case NORTH:
        AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle", true);
        break;
     case EAST:
        AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle_right", true);
        break;
     case SOUTH:
        AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle", true);
        break;
     case WEST:
        AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle_left", true);
        break;
     case NORTH_EAST:
        AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle_right", true);
        break;
     case SOUTH_EAST:
        AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle_right", true);
        break;
     case SOUTH_WEST:
        AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle_left", true);
        break;
     case NORTH_WEST:
        AnimationState_setAnimationByName(m_pDrawable->state, 0, "idle_left", true);
        break;
     default:
        break;
     }
     break;
  default:
     break;
  }
}

The big switch block is currently needed because all animation are named differently. Once they are all named "idle" or "running" I will replace it with this:

AnimationState_setAnimationByName(m_pDrawable->state, 0, m_movingDirection == NONE ? "idle" : "running", true);

Initially I set the viewingdirection to south and update the movingdirection to NONE. So the south idle animation is played.

m_viewingDirection = SOUTH;
updateMovingDirection(NONE);

Then I update the Skeleton (no matter what):

m_pDrawable->skeleton->x = getPosition().x + 64;
m_pDrawable->skeleton->y = getPosition().y + 128;
m_pDrawable->update(elapsedTime.asSeconds());

Drawing:

m_pDrawable->skeleton->a = m_isInvisible || m_isDead ? 100.f : 1.f;  //make him transparent

target.draw(*m_pDrawable, states);

And that's it. I got no clue what could cause a problem...