Bug Report and Automation question

lono

Hi, i believe you have a bug in SkeletonGraphicInspector, for button "Detect Settings"

if (GUILayout.Button("Detect Settings", EditorStyles.miniButton, GUILayout.Width(100f))) { Undo.RecordObjects(targets, "Detect Settings"); foreach (Object targets in targets) { SkeletonGraphic skeletonGraphic = target as SkeletonGraphic; if (skeletonGraphic == null) continue; DetectTintBlack(skeletonGraphic); DetectCanvasGroupCompatible(skeletonGraphic); DetectPMAVertexColors(skeletonGraphic); } }

The foreach Object iteration object is called targets, but should be called target, inside foreach target as SkeletonGraphic accesses the base target reference and not the each Object target.

Second thing is question of automation, i have a lot of prefabs with graphic skeleton graphic renderers.
I created a editor windows which knows if i have selected a prefab content with skeleton component. With a click of a single button in unity editor window i want to alter couple of settings.

Doing this by hand for many prefabs is error prone.
I want to change PMA vertex colors true/false and canvas group compatible true/false under advanced settings, how can i do this the correct way ?

Thank you.

Harald

lono The foreach Object iteration object is called targets, but should be called target, inside foreach target as SkeletonGraphic accesses the base target reference and not the each Object target.

You are absolutely right, thanks for bringing this to our attention!
We've just published a bugfix for this issue.

lono

I know this is a bot just pointing out that these settings are stored inside

t.MeshGenerator.settings

which is a struct.

Thanks for posting the correction. Spinebot was confusing SkeletonRenderer with SkeletonGraphic of version 4.2 it seems.

On 4.2 it's accessed as skeletonGraphic.MeshGenerator.settings and was still a struct.
On 4.3-beta an newer it's unified for SkeletonRenderer and SkeletonGraphic and accessed via skeletonGraphic.MeshSettings and is a class.

I can assign new struct to it with fresh settings but do i need to call t.UpdateMesh(); or t.Initialize(false) after. This is in non-play mode, unity editor scope only.

I'm not sure I understand your question correctly, but in general there is no need to call UpdateMesh() or Initialize(false) if you're just modifying prefab values here, as these calls don't modify any persisted values. They are just needed when you want to update the displayed mesh in the same frame and not a frame later. Regarding prefabs, when the respective prefab is loaded the mesh is re-generated according to the persisted values anyway. If you meant something else with your question please let me know.

Spinebot

The issue you've identified in the SkeletonGraphicInspector script is indeed a mistake. The foreach loop should iterate over each Object in targets, and the variable should be named target to avoid confusion with the targets array. This would ensure that each SkeletonGraphic is correctly accessed and modified.

For automating the process of altering settings for multiple prefabs, you can create an editor script that iterates over your prefabs, loads them, and modifies the desired properties. Here's a basic example of how you might achieve this:

using UnityEditor;
using UnityEngine;
using UnityEngine.UI;

public class PrefabModifier : EditorWindow {
    [MenuItem("Window/Prefab Modifier")]
    public static void ShowWindow() {
        GetWindow<PrefabModifier>("Prefab Modifier");
    }

    private void OnGUI() {
        if (GUILayout.Button("Modify Prefabs")) {
            ModifyPrefabs();
        }
    }

    private void ModifyPrefabs() {
        string[] guids = AssetDatabase.FindAssets("t:Prefab");
        foreach (string guid in guids) {
            string path = AssetDatabase.GUIDToAssetPath(guid);
            GameObject prefab = AssetDatabase.LoadAssetAtPath<GameObject>(path);
            if (prefab != null) {
                SkeletonGraphic skeletonGraphic = prefab.GetComponentInChildren<SkeletonGraphic>();
                if (skeletonGraphic != null) {
                    Undo.RecordObject(skeletonGraphic, "Modify SkeletonGraphic Settings");
                    var settings = skeletonGraphic.MeshGenerator.settings;
                    settings.canvasGroupCompatible = true;
                    settings.pmaVertexColors = false;
                    skeletonGraphic.MeshGenerator.settings = settings; // in 4.2 MeshGenerator.settings is a struct
                    EditorUtility.SetDirty(skeletonGraphic);
                }
            }
        }
        AssetDatabase.SaveAssets();
    }
}

This script creates a custom editor window with a button that, when clicked, iterates over all prefabs in the project, checks if they contain a SkeletonGraphic component, and toggles the canvasGroupCompatible and pmaVertexColors properties. Adjust the logic as needed to set the properties to specific values rather than toggling them.

lono

Spinebot

I know this is a bot just pointing out that these settings are stored inside

t.MeshGenerator.settings

which is a struct. I can assign new struct to it with fresh settings but do i need to call t.UpdateMesh(); or t.Initialize(false) after. This is in non-play mode, unity editor scope only.

lono

Harald

Hi and thank you for responding. Here is a snippet, note again this is in non-play mode for prefabs only, as I understand UpdateMesh() not Initialize() is not required at the end correct?

Another suggestion: from my custom code i want to call static methods DetectMaterial() and DetectBlendModeMaterials() but they are inside SkeletonGraphicInspector and private, using reflection for me is fine as its editor only anyway. I would suggest bringing them out to some public EditorUtility as its really not inspector only related and blocks from custom automation, just my 2 cents, thank you.

public bool autoDetectMaterial = true;
    public bool autoDetectBlendModeMaterials = true;
    public MeshGenerator.Settings settings = new MeshGenerator.Settings {
        pmaVertexColors = false,
        zSpacing = 0f,
        useClipping = true,
        tintBlack = false,
        calculateTangents = false,
        addNormals = false,
        immutableTriangles = false,
        canvasGroupCompatible = true
    };
    public bool allowMultipleCanvasRenderers = true;
    public bool startingLoop = false;
    public bool raycastTarget = false;

    t.MeshGenerator.settings = settings;
    t.allowMultipleCanvasRenderers = allowMultipleCanvasRenderers;
    t.startingLoop = startingLoop;
    t.raycastTarget = raycastTarget;

    if (autoDetectMaterial)
    {
        TryAutoDetect("DetectMaterial", t);
    }

    if (autoDetectBlendModeMaterials)
    {
        TryAutoDetect("DetectBlendModeMaterials", t);
    }
        
    t.UpdateMesh();

private static void TryAutoDetect(string methodName, SkeletonGraphic skeletonGraphic)
    {
        var type = typeof(SkeletonGraphicInspector);

        // Find the private static method
        var method = type.GetMethod(methodName, BindingFlags.NonPublic | BindingFlags.Static);

        if (method != null)
        {
            // Pass arguments as an object array
            object[] parameters = { skeletonGraphic };
            method.Invoke(null, parameters);
        }
        else
        {
            Debug.LogError($"Could not find method '{methodName}'!");
        }
    }

Harald

lono Hi and thank you for responding. Here is a snippet, note again this is in non-play mode for prefabs only, as I understand UpdateMesh() not Initialize() is not required at the end correct?

Exactly, no need for calling UpdateMesh() or Initialize().

lono Another suggestion: from my custom code i want to call static methods DetectMaterial() and DetectBlendModeMaterials() but they are inside SkeletonGraphicInspector and private, using reflection for me is fine as its editor only anyway. I would suggest bringing them out to some public EditorUtility as its really not inspector only related and blocks from custom automation, just my 2 cents, thank you.

You're absolutely right, thanks for bringing this to our attention. The methods have been moved to a new class SkeletonGraphicUtility on the 4.3-beta branch (in this commit). A new spine-unity 4.3-beta unitypackage has been released as well:
https://esotericsoftware.com/spine-unity-download