[Unity+tk2d] Bonecomponent doing weird Z-position things

SullyTheStrange

So I just started using Bonecomponent to attach colliders, but for some reason every time an animation for the bone fires, the attached collider gets pushed further and further down the Z-axis. Like, hundreds and thousands of units further, which is clearly an issue.

I can't think of anything my animations are doing that would cause this, but why would Bonecomponent ever need to affect Z-position, if the animations are strictly 2D? Is this a bug or some functionality I'm not aware of?

SullyTheStrange

Pharan

BoneComponent's kinda buggy right now. Doesn't detect flips. Transform caching is a bit weird. Stuff like that.
I promised Nate I'd fix it soon after skinning was implemented but I haven't gotten to doing it yet. Someone else wrote the original code and I modified it a bit.

I'll take a look at it now. From what I remember though, it always took the z position of its parent, or if it's parented under the SkeletonAnimation's transform, its local z is always 0. I think.

Can you describe to me how you're using BoneComponent or how you intend to use it?
Are you attaching it programmatically? Or is it already part of a prefab? Do you need it to be parented under the SkeletonAnimation's Transform?

I'm not sure what the math behind this does but I assume that's what's causing your problems:

cachedTransform.position = skeletonTransform.TransformPoint(new Vector3(bone.worldX, bone.worldY, cachedTransform.position.z));

I'll continue looking.
I'm suspecting this has something to do with scale affecting the positions.

SullyTheStrange

I used it two different ways, one as part of a prefab and a child of the SkeletonAnimation, and then one that isn't a prefab and isn't a child. I got similar behavior in both cases (though it looks like the prefab/child one isn't pushing AS far down the Z-axis as the other one). For now I'm just working around it by attaching a script that zeroes out the Z position every frame, but it'd be nice to not have to deal with it. :p

Also, I'm noticing that the dropdown Bone field for Bonecomponent in the inspector likes to disappear sometimes until you click on a few other objects and then click back. Not a huge deal but that might warrant a look too.

Pharan

I found the problem, but there's a bit of an ambiguous case here.

If you just want the BoneComponent to follow the SkeletonRenderer's Transform's Z position though, you should replace this line:

cachedTransform.position = skeletonTransform.TransformPoint(new Vector3(bone.worldX, bone.worldY, cachedTransform.position.z));

with this line

cachedTransform.position = skeletonTransform.TransformPoint(new Vector3(bone.worldX, bone.worldY, 0f));

Yeah, I noticed that the dropdown disappears every now and then too.
I don't have much experience writing Inspector scripts so I don't know if I can do much there.

SullyTheStrange

Awesome, I'll try that out. Thanks!

The Inspector thing might have to do with the fact that Bonecomponent is functional in-editor too instead of just in-game, but yeah, I don't know anything about that stuff either.

Pharan

Turns out it wasn't as buggy as I originally thought, but I'll be doing a PR of an updated BoneComponent in a bit.